Fix collapsing of multiple Header::Other in responses#89
Merged
yeoleobun merged 1 commit intorestsend:mainfrom Jan 23, 2026
Merged
Fix collapsing of multiple Header::Other in responses#89yeoleobun merged 1 commit intorestsend:mainfrom
yeoleobun merged 1 commit intorestsend:mainfrom
Conversation
FedorKiselev76
force-pushed
the
fix-other-headers
branch
from
20c5e5f to
93eb739
Compare
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DialogInner::make_response() uses unique_push() for all headers, which causes all Header::Other(...) headers to be treated as a single entry.
As a result, multiple custom headers (e.g. X-*) are collapsed into one and lost in SIP responses.