Refactor dialog transition return type#92
Closed
adamchol wants to merge 1 commit intorestsend:mainfrom
Closed
Conversation
Collaborator
|
Yes, there are lot of things like this. Some are pattern, some inner Error are removed or just logged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small simplification which makes rejecting calls return unit instead of
Result<()>.I noticed that
DialogInner::transition()doesn't actually returnErr(_)ever, so I just changed the return type to unit.There might be more cases like that in the codebase.