Fixed: Parsing of WebVTT subtitles which contain text after the WEBVTT keyword #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
|
Indeed. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional description
Fixing helper that converts WebVTT to SRT subtitle format for WebVTT files with a slightly uncommon format.
Reasoning
NRK was consistently using a format that the parser didn't handle appropriately, which broke most, if not all subtitles on NRK.
Technical description
According to https://www.w3.org/TR/webvtt1/#webvtt-file-body the WebVTT format allows arbitrary text after the "WEBVTT" keyword. With the previous parser implementation those lines where not ignored like they should.