Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
this is one out of two PR's. I hope you find them beneficial.
I added optional GPU support to the Dockerfile. The current image only works with CPU. With
--build-arg GPU=1it uses a CUDA base image and pulls the CUDA torch wheels.This enables
--device cudafor the node.The way this works is a bit ugly (Docker doesn't have proper conditionals for FROM), but it keeps the CPU images slim.
The downside is that the build will download the CUDA base image even when building for CPU, but it won't be included in the final result. Since these are built on CI anyway, I wouldn't mind this much personally.
Default is GPU=0 so nothing breaks for existing builds.
(I chose
cu126because it still supports older GPU's such as the 1080. Newer wheels would exclude them, but they still perform quite good with Whisper.)Cheers