Create camera-capture element and an element for logging#35
Create camera-capture element and an element for logging#35kenchris wants to merge 4 commits intoriju:masterfrom
Conversation
- These new elements uses material design and are build into build/elements using rollupjs.
riju
left a comment
riju
left a comment
There was a problem hiding this comment.
Thank you! The UX makeover looks cool ;) let fix some nits.
| } | ||
| }); | ||
|
|
||
| // Android bug, doesn't work with DevTools emulation. |
There was a problem hiding this comment.
Not filed, but can you look at it and debug with Sasha?
There was a problem hiding this comment.
She had a similar workaround that broke devtools emulation
| <settings-slider metering label="Focus distance" id="focusDistance" min="0" max="10" value="0" step="1"></settings-slider> | ||
| </div> | ||
| <div id="standardSettings" class="pro-settings hidden"> | ||
| <settings-slider label="Contrast" id="contrast" min="0" max="10" value="0" step="1"></settings-slider> |
|
|
||
| facingMode = "user"; | ||
|
|
||
| _onResetClicked(e) { |
There was a problem hiding this comment.
How about reset-ing state per settings group ? Like it was before, so that we have more fine grained control of things we are resetting
| this.constraints.height = Math.ceil(visualViewport.height); | ||
| } | ||
|
|
||
| // Disable facingModeButton if there is no environment or user mode. |
There was a problem hiding this comment.
Let's elaborate a bit more on the comment, as we discussed ? Do we want to treat that icon as a camera switcher (say 2 user facing mode cameras on a laptop, the inbuilt and an external one), or a facing mode switcher like say on Android, (front/user and back/environment)
There was a problem hiding this comment.
Switching camera on a mobile phone with just two cameras is the exact same behavior as switching between front and back
| constraints.advanced[0]['whiteBalanceMode'] = 'manual'; | ||
| } | ||
|
|
||
| this.dispatchEvent(new CustomEvent('constraintschange', { detail: { constraints } })); |
There was a problem hiding this comment.
Now the constraintschange change event is fired on mouse up, previously we changed it instantly on slider value change. Can we change the functionality to what it was ?
2 participants
These new elements uses material design and are build into build/elements using rollupjs.
Fixes: #14