-
Notifications
You must be signed in to change notification settings - Fork 151
feat(examples): add tanstack start example #4095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🚅 Deployed to the rivet-pr-4095 environment in rivet-frontend
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Test" took an action on this PR • (02/02/26)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
2e65fc4 to
67218a3
Compare
PR Review: TanStack Start ExampleSummaryThis PR adds a new example demonstrating RivetKit integration with TanStack Start. The example implements a real-time counter with persistent state, showcasing actor actions, state management, and events. ✅ Strengths
🔍 Issues & RecommendationsCritical Issues1. Missing Vercel Example Generation Action Required:
2. Redundant Technology Entry ( { name: "react", displayName: "React" }, // Line 6
// ... other entries ...
{ name: "react", displayName: "React" }, // Line 20 (duplicate)
{ name: "tanstack-start", displayName: "TanStack Start" },This appears to be an accidental duplication when adding the tanstack-start entry. Code Quality Issues3. Missing Error Handling ( counter.connection.getCount().then(setCount);This Promise is not handling potential errors. Consider: counter.connection.getCount()
.then(setCount)
.catch(err => console.error('Failed to get count:', err));4. Template Metadata Formatting ( 5. Comment Style ( // Use connStatus from the hook instead of tracking connection state manuallyThis comment documents what was removed/changed. According to CLAUDE.md, documenting deltas is not useful for developers who haven't worked on the project before. Consider removing or rephrasing to explain the current approach without referencing what changed. Documentation Issues6. Incomplete PR Template
Minor Issues7. Generated File in PR ( 8. Missing Test Coverage
🔒 Security ConsiderationsNo major security issues found. The code:
⚡ Performance Considerations
Recommendation: Consider adding loading states for the initial 📝 Recommendations SummaryMust Fix Before Merge
Should Fix
Nice to Have
✨ Overall AssessmentThis is a solid example that demonstrates TanStack Start integration well. The code is clean, follows RivetKit patterns correctly, and the documentation is thorough. The main issues are:
Recommendation: Request changes for the duplicate entry and Vercel clarification, then approve once addressed. |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: