[Graphite MQ] Draft PR GROUP:spec_87fbdc (PRs 4056, 4100, 3666, 4142, 4143, 4140)

[graphite-app]

This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.

The following PRs are included in this draft PR:

• #4056
• #4100
• #3666
• #4142
• #4143
• #4140

[railway-app]

This PR was not deployed automatically as @graphite-app[bot] does not have access to the Railway project.

In order to get automatic PR deploys, please add @graphite-app[bot] to your workspace on Railway.

[claude]

PR Review - Graphite Merge Queue #4146

This PR combines 6 PRs focusing on example improvements, dashboard UI, and SQLite features. Overall code quality is excellent, but there are critical documentation issues that must be fixed before merge.

---

🔴 Critical Issues (Must Fix)

1. Incorrect Directory Paths in Vercel READMEs

Files affected:

• examples/ai-agent-vercel/README.md:14
• examples/collaborative-document-vercel/README.md:14
• examples/multiplayer-game-vercel/README.md:14
• examples/geo-distributed-database-vercel/README.md:14

Problem: READMEs say cd rivet/examples/ai-agent but should say cd rivet/examples/ai-agent-vercel

Impact: Users will navigate to wrong directory when following Vercel example instructions.

---

2. Wrong GitHub Organization in Deploy Buttons

Files affected: All *-vercel/README.md files (line 4)

Problem: Deploy buttons use https://github.com/rivet-gg/rivet/... instead of rivet-dev/rivet

Impact: Violates CLAUDE.md requirement to use rivet-dev (never rivet.gg). Deploy buttons point to wrong repository.

---

3. Incorrect Vercel Framework Configuration

Files affected: All *-vercel/vercel.json files

Problem: Using "framework": "vite" instead of "framework": "hono"

Per CLAUDE.md:

Vercel auto-detects Vite when it sees a vite.config.ts and ignores Hono. We must explicitly set the framework to Hono.

Impact: May cause deployment issues on Vercel due to framework auto-detection conflict.

---

🟡 Non-Blocking Issues (Should Fix)

4. Missing .gitignore Files

• examples/collaborative-document/
• examples/geo-distributed-database/

Should include:

.actorcore
node_modules

---

5. Hardcoded RivetKit Versions

All examples use "rivetkit": "^2.0.38" instead of "*" per CLAUDE.md guidelines.

Note: This appears systematic across examples - may indicate outdated guidance or intentional deviation.

---

6. Minor Style Inconsistencies

• geo-distributed-database/turbo.json uses spaces instead of tabs
• Inconsistent error handling formatting in main.tsx files

---

✅ Excellent Work

Code Quality

• Perfect parity between local and Vercel versions
• Clean actor implementations following RivetKit patterns
• Proper TypeScript typing throughout
• No security vulnerabilities (XSS, injection, exposed secrets)
• ESM compliance with .ts extensions

Architecture

• Correct coordinator pattern usage
• Proper state management with createState
• Clean event broadcasting with c.broadcast()
• Proper connection cleanup in onDisconnect

Documentation

• Well-structured READMEs following template
• Clear, complete sentences in comments
• Good linking to documentation

Performance

• Efficient React patterns with proper hooks usage
• Proper cleanup of event listeners
• Abort signal handling in AI agent

---

📋 Summary

Recommendation: Request changes for the 3 critical documentation issues

Blocking Issues: 3 (README paths, GitHub org, Vercel config)
Non-Blocking Issues: 3 (minor style/consistency)

The code itself is production-ready with excellent architecture and no security concerns. However, the documentation errors would cause significant confusion for users trying to deploy the Vercel examples.

Quick Fix Checklist

• Update all Vercel README paths to match directory names
• Change all Deploy button URLs from rivet-gg to rivet-dev
• Change vercel.json framework from "vite" to "hono"
• Add .gitignore files to new examples
• Fix turbo.json indentation to use tabs

---

Review performed by Claude Code Agent - Learn more