Skip to content

chore: fix bad patch#4154

Draft
MasterPtato wants to merge 1 commit intomainfrom
02-06-chore_fix_bad_patch
Draft

chore: fix bad patch#4154
MasterPtato wants to merge 1 commit intomainfrom
02-06-chore_fix_bad_patch

Conversation

@MasterPtato
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Feb 7, 2026

🚅 Deployed to the rivet-pr-4154 environment in rivet-frontend

Service Status Web Updated (UTC)
website ❌ Build Failed (View Logs) Web Feb 7, 2026 at 12:41 am
frontend-inspector ❌ Build Failed (View Logs) Web Feb 7, 2026 at 12:40 am
mcp-hub ✅ Success (View Logs) Web Feb 7, 2026 at 12:40 am
frontend-cloud ❌ Build Failed (View Logs) Web Feb 7, 2026 at 12:40 am

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Feb 7, 2026

PR Review

Summary

This PR removes the ?current_event field from a tracing::error! log statement in the workflow history corruption detection code.

Analysis

Change Details:

  • File: engine/packages/gasoline/src/db/kv/mod.rs:1654
  • What changed: Removed ?current_event from structured logging parameters
  • Context: Error logging for corrupt workflow history when indexed chunks are out of order

Findings

Code Quality - Good

The change maintains consistent logging patterns. Looking at the similar error at line 1636-1639 for indexed names, it also logs only ?wf without logging current_event, so this change brings consistency.

⚠️ Observability Consideration

While the change improves consistency, it does reduce diagnostic information. The current_event variable contains:

  • indexed_input_chunks (the data structure being validated)
  • Other workflow event metadata that could be helpful for debugging

Recommendation: Consider whether the reduced observability is intentional. If debugging corrupt history issues becomes difficult, you might want to add back selective fields like indexed_input_chunks_len = current_event.indexed_input_chunks.len() instead of the full struct.

No Functional Impact

This is purely a logging change - no behavioral changes to the workflow engine.

Performance

Slight performance improvement by not serializing the current_event struct for logging.

Conclusion

The change is correct and maintains consistency with similar error logging in the same function. The PR title "fix bad patch" suggests this may have been an unintended addition that's being corrected.

Verdict:Approve - The change is safe and improves consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant