fix(agent-management): pass env vars to agent in spawn_streaming#59
Open
gregce wants to merge 1 commit intorivet-dev:mainfrom
Open
fix(agent-management): pass env vars to agent in spawn_streaming#59gregce wants to merge 1 commit intorivet-dev:mainfrom
gregce wants to merge 1 commit intorivet-dev:mainfrom
Conversation
The spawn_streaming() function was not passing environment variables from SpawnOptions.env to the spawned process. This caused agents like Claude to not receive ANTHROPIC_API_KEY, resulting in silent authentication failures. The non-streaming spawn() method correctly passes env vars (lines 298-300), but spawn_streaming() was missing this code path. This fix adds the same env var loop to spawn_streaming(), ensuring that credentials extracted from the host environment are properly passed to spawned agents.
Author
|
@NathanFlurry per this conversation on X My code is effectively the same as your e2b example: https://github.com/rivet-dev/sandbox-agent/blob/main/examples/e2b/src/e2b.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn_streaming()to pass environment variables fromSpawnOptions.envto spawned processesspawn()method correctly passes env vars, butspawn_streaming()was missing this code pathANTHROPIC_API_KEY, resulting in silent authentication failuresTest plan
🤖 Generated with Claude Code