fix: Invoke-DataverseSql doesn't respond to CTRL+C#1410
Open
fix: Invoke-DataverseSql doesn't respond to CTRL+C#1410
Conversation
Co-authored-by: rnwood <1327895+rnwood@users.noreply.github.com>
- Pass cancellation token to ExecuteReaderAsync to enable query cancellation - Add checks for cancelled/faulted tasks before accessing results - Remove outdated comment about SQL4CDS not supporting cancellation Co-authored-by: rnwood <1327895+rnwood@users.noreply.github.com>
- Remove unnecessary Task.Run wrapper around ExecuteReaderAsync - Simplify exception handling to let task.Result propagate exceptions naturally Co-authored-by: rnwood <1327895+rnwood@users.noreply.github.com>
- task.Result naturally propagates exceptions, making the separate IsFaulted check unnecessary - Simplifies code and improves clarity Co-authored-by: rnwood <1327895+rnwood@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix invoke-dataversesql not responding to CTRL+C
fix: Invoke-DataverseSql doesn't respond to CTRL+C
Feb 6, 2026
rnwood
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Invoke-DataverseSqlignored CTRL+C during query execution, only responding after results began streaming. The cmdlet'sStopProcessing()method created a cancellation token but never passed it to the underlying SQL4CDS engine.Changes Made
_userCancellationCts.TokentoExecuteReaderAsync()to enable query cancellationIsCanceledcheck before accessing task result to handle graceful cancellationTask.Runwrapper (unnecessary -ExecuteReaderAsyncalready returns a Task)Key change:
Testing
Checklist
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.