Skip to content

Conversation

@justforjan
Copy link

@justforjan justforjan commented Feb 1, 2026

I have read the CLA Document and I sign the CLA.

Remove automatic distributed mode in slurm cluster as this is not alw…ays required, especially in smaller clusters with smaller experiments

What does this PR do?

This PR removes the automatic distributed mode in slurm clusters. Especially, in smaller cluster with smaller experiments, this add unnecessary overhead.

Type of Change

  • Other: remove automatic functionality

Testing

  • I have tested this change locally
  • I have added/updated tests for this change

Test details:
In Slurm clusters it is now sufficient to run python ... instead of, e.g., torchrun -nproc_per_node 1 ... + handling of error when training finishes.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors
  • I have updated the documentation accordingly (if applicable)

Additional Context

…ays required, especially in smaller clusters with smaller experiments
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Jan Privat seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22%. Comparing base (35ac6ab) to head (f851cc3).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
@@          Coverage Diff           @@
##           develop   #623   +/-   ##
======================================
  Coverage       22%    22%           
======================================
  Files           46     46           
  Lines         6182   6179    -3     
======================================
  Hits          1343   1343           
+ Misses        4839   4836    -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's don't edit this file...

@Borda Borda marked this pull request as draft February 9, 2026 14:55
@Borda Borda marked this pull request as draft February 9, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants