Skip to content

Remove unnecessary color normalization#869

Merged
benkiel merged 7 commits intorobotools:v1from
knutnergaard:color
Jan 29, 2026
Merged

Remove unnecessary color normalization#869
benkiel merged 7 commits intorobotools:v1from
knutnergaard:color

Conversation

@knutnergaard
Copy link
Contributor

No description provided.

@benkiel
Copy link
Member

benkiel commented Jan 29, 2026

I’m not sure it is unnecessary, _get_color doesn't run the normalizer, so _base_get_color is on the value returned from the that function.

@knutnergaard
Copy link
Contributor Author

This is due to the revamped Color object, which also runs the normalizer. I already had removed the call in some get_base_color cases, but had forgot about these.

It may be cleaner to convert color values to Color more consistently, rather than calling normalizeColor, but I'm not sure.

@benkiel
Copy link
Member

benkiel commented Jan 29, 2026

Ah, got it. Thanks for jogging my memory!

@benkiel benkiel merged commit ab1d4d0 into robotools:v1 Jan 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants