Draft
Conversation
Member
|
Probably vcstools/vcstools#147. |
Member
Author
|
This is no longer a VCS issue. We're now dealing with a PUT build issue: |
6c4b4b7 to
e6befa6
Compare
Member
Author
|
From looking at the source code for the PUT, I very strongly suspect that the buggy version does not build. The buggy commit attempts to refactor part of In addition to fixing the bug described in the bug report, the fix commit actually rolls back the attempted refactoring. In short: I think that the behaviour we're seeing is accurate, but that we're actually dealing with multiple, independent bug fixes in a single commit. |
Member
Author
|
The fix commit belongs to a much bigger PR that adds support for MAVLink 2.0: mavlink/mavros#554 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fails to download source for PUT: