RigidBodyStateVisualisation changes#166
Open
pierrewillenbrockdfki wants to merge 3 commits intomasterfrom
Open
RigidBodyStateVisualisation changes#166pierrewillenbrockdfki wants to merge 3 commits intomasterfrom
pierrewillenbrockdfki wants to merge 3 commits intomasterfrom
Conversation
This would break endless recursion if the receiver of propertyChanged has other callers than the visualisation and also wants to keep the visualisation updated, which seems to not have been an issue, yet. Also a slight performance benefit.
This allows display of the coordinate system of the targetframe as viewed from the sourceframe. Previously, the only useful way to setup the view in regards to the other transformations was to set the frame of the visualisation to the targetFrame, and the model/coordinate cross would appear at the origin of the sourceFrame. Setting displayTargetInSource to true, one would then set the visualisation frame to the sourceFrame and get the coordinate cross(and model) at the origin of the targetFrame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a collection of cleanups and changes i had laying around. Instead of copying them around forever, i thought i would offer them here.
These should not change behavior, except: use less resources when a property is set to the same value it already has, update the displayed model when certain properties are changed(instead of relying on new data to do the same), or if the new displayTargetInSource property is used.