chore: remove flavor-related sanity checks

[doudou]

I don't have the time to remove it completely, but that part is safe enough.

[planthaber]

Is the idea to remove flavors completely?

Then I'd also remove the configuration option, and add deprecation warnings to the functions (with instructions to set the ROCK_SELECTED_FLAVOR manually, if required)

https://github.com/rock-core/package_set/blob/master/init.rb#L61-L142

[doudou]

Is the idea to remove flavors completely?

Rather obviously, since 'stable' is pre-2016 I think ... or even earlier.

Then I'd also remove the configuration option, and add deprecation warnings to the functions (with instructions to set the ROCK_SELECTED_FLAVOR manually, if required)

https://github.com/rock-core/package_set/blob/master/init.rb#L61-L142

As I said. I don't have time to do the whole removal. If you volunteer, be my guest.

[pierrewillenbrockdfki]

Looks good to me.

[planthaber]

Do we actually need deprecation?

I think we could also just remove the functionality, as it wasn't used for a long time.

[planthaber]

Created a PR to this branch to also remove leftover stuff: #246

[doudou]

Do we actually need deprecation?

I think we could also just remove the functionality, as it wasn't used for a long time.

Agreed. I did not add deprecations...