fix(zxcvbn): Password exceeds max length of 72 characters.

[aboettger-tuhh]

A robust analysis for zxcvbn results has been added to handle missing keys and output user-friendly messages. The cause was the following exception:

Traceback (most recent call last):
  File "/home/<censored>/.local/bin/pimport", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/<censored>/.local/share/pipx/venvs/pass-import/lib/python3.12/site-packages/pass_import/__main__.py", line 512, in main
    paths_imported, paths_exported, audit = pass_export(conf, cls_export, data)
                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/<censored>/.local/share/pipx/venvs/pass-import/lib/python3.12/site-packages/pass_import/__main__.py", line 400, in pass_export
    report = exporter.audit(conf['pwned'])
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/<censored>/.local/share/pipx/venvs/pass-import/lib/python3.12/site-packages/pass_import/manager.py", line 186, in audit
    audit.zxcvbn()
  File "/home/<censored>/.local/share/pipx/venvs/pass-import/lib/python3.12/site-packages/pass_import/audit.py", line 95, in zxcvbn
    results = zxcvbn(password, user_inputs=user_input)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/<censored>/.local/share/pipx/venvs/pass-import/lib/python3.12/site-packages/zxcvbn/__init__.py", line 10, in zxcvbn
    raise ValueError(f"Password exceeds max length of {max_length} characters.")
ValueError: Password exceeds max length of 72 characters.

[roddhjav]

I think you forgot a self here?

[nrth3rnlb]

Yes, it could be.

[Goorzhel]

Why not move zxcvbn_parse outside the class, since that function is not using self at all?

[nrth3rnlb]

My patch is more of a quick and dirty hack. I don’t think I can contribute anything more intelligent without delving deeper into the code.

[Goorzhel]

Here's something quicker and dirtier, then: #232