Skip to content

Regularization TV additions#53

Open
RainerHeintzmann wants to merge 7 commits intoroflmaostc:masterfrom
RainerHeintzmann:regularization
Open

Regularization TV additions#53
RainerHeintzmann wants to merge 7 commits intoroflmaostc:masterfrom
RainerHeintzmann:regularization

Conversation

@RainerHeintzmann
Copy link
Contributor

This is a slightly revised way to handle CUDA and TV.
However, note that the following two lines of test have been removed:
@test TV_cuda(num_dims=2)(x) ≈ reg(x)
@test TV_cuda(num_dims=3)(x) ≈ reg(x)

Is this acceptable?

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 50.00000% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.63%. Comparing base (57ae209) to head (578e54a).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/regularizer_cuda.jl 23.07% 20 Missing ⚠️
src/regularizer.jl 76.47% 4 Missing ⚠️
src/analysis_tools.jl 62.50% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (57ae209) and HEAD (578e54a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (57ae209) HEAD (578e54a)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   91.39%   82.63%   -8.76%     
==========================================
  Files          13       13              
  Lines         616      622       +6     
==========================================
- Hits          563      514      -49     
- Misses         53      108      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RainerHeintzmann
Copy link
Contributor Author

... I now made it compatible with Optim Version 2.0. However this meant to return "missing" as time values in the trace callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants