Clean Up DrillManager.py codebase

[ALP2023]

This issue is closed and now in review status - removed defunct code from DrillManager.py

Issue

Although the DrillManager.py document has detailed comments for functions and methods for the DrillManager Class, it contains a substantial amount of defunct commented-out code. This impacts the maintainability and readability of the codebase.

Why

• Helps in understanding the current state of the code.
• Reduces confusion.
• Streamlines development process.
• Reduces file size, even though commented-out code doesn’t execute, and helps in maintaining a more manageable codebase.
• Unused code may contain vulnerabilities or security issues that were fixed in the active code.

Tasks

• Review existing documentation for DrillManager.py.
• Remove defunct/commented-out code.
• Check no active code was erroneously deleted, i.e. check functionality in QGIS.

[rolandhill]

Hi April,

The changes to DrillManager.py look fine to me. Be careful not to commit additional files, particularly those associated with your editor. There are several files in the .idea/ directory that I will ignore.

Cheers,
Roland

[rolandhill]

Actually, you might need to modify your PR and remove those .idea/ files first. My PR skills don't extend that far.

[ALP2023]

Thanks Roland. Yeah I'd noted that too, need to go back have a look at my idea file. Been a rush job, my Web design crunched up a lot of time. I've done a few more but didn't do a pull request as I haven't tested it on QGIS. Thankfully this assessment is more about communication and gitbhub. OMG I'm not going to study full time whilst working concurrently again. Kids have banned me from doing so 🤣. Really appreciate all your assistance. Maybe one day I'll be brave enough to write a plugin to automate some of my repetitive tasks on QGIS! Cheers April

…

On Wed, 6 Dec 2023, 2:24 pm Roland Hill, ***@***.***> wrote: Actually, you might need to modify your PR and remove those .idea/ files first. My PR skills don't extend that far. — Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A62CPLIG7Y4RCS4JCH2IP4DYIAFRVAVCNFSM6AAAAABADU5UESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBSGE3DQNJSGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>