-
Notifications
You must be signed in to change notification settings - Fork 2
Covers the file creation events by tests #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds test coverage for file creation events and introduces infrastructure to simplify event testing. The main changes include a new EventCollector utility class for collecting and waiting on filesystem events, and updates to the NotifierT interface to support stopping the notifier.
- Introduced
EventCollectorclass to streamline event collection and waiting in tests - Added test coverage for file creation events
- Updated
NotifierTprotocol to include thestop()method
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_events_create.py | New test file that validates file creation events are properly detected and collected |
| tests/conftest.py | Introduces EventCollector helper class for managing event collection in async tests |
| pytest.ini | Configures pytest for async test execution |
| pyproject.toml | Adds required test dependencies (async-timeout, pytest-asyncio) |
| notifykit/_notifier.py | Adds stop() method to NotifierT protocol interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tests/conftest.py
Outdated
|
|
||
|
|
||
| class EventCollector: | ||
| def __init__(self, ): |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary trailing comma and space in the __init__ parameter list. Should be def __init__(self):.
| def __init__(self, ): | |
| def __init__(self): |
c-h-russell-walker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Uh oh!
There was an error while loading. Please reload this page.