[ROMM-3025] Fix collections with custom art failing

[gantoine]

Description
^{Explain the changes or enhancements you are proposing with this pull request.}

Checklist
^{Please check all that apply.}

• I've tested the changes locally
• I've updated relevant comments
• I've assigned reviewers for this PR
• I've added unit tests that cover the changes

Screenshots (if applicable)

[gemini-code-assist]

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where collections with custom artwork were failing to be handled correctly. The changes streamline the process of uploading and displaying custom cover images for collections and ROMs by renaming related functions for better clarity, ensuring that uploaded file data is properly assigned, and updating the image preview state. Additionally, a minor adjustment was made to the collection creation payload to prevent unintended side effects.

Highlights

• Function Renaming for Clarity: The setArtwork function was consistently renamed to setCoverUrl or setUrlCover across multiple components (CollectionInfoDrawer.vue, CreateCollection.vue, EditRom.vue) to improve clarity and semantic accuracy regarding its purpose of handling cover image URLs.
• Enhanced Custom Artwork Handling: Logic for previewing and assigning custom uploaded artwork was enhanced in CollectionInfoDrawer.vue, CreateCollection.vue, and EditRom.vue. This now correctly sets the artwork property on the respective collection or rom objects and ensures the image preview and removeCover flag are updated.
• Collection Creation Payload Update: In CreateCollection.vue, the createCollection function was updated to pass a shallow copy of the collection.value object using the spread operator, ensuring that the API call receives a clean object and avoids potential reactivity issues.

Changelog

• frontend/src/components/Gallery/AppBar/Collection/CollectionInfoDrawer.vue
  • Renamed setArtwork function to setCoverUrl.
  • Updated previewImage function to assign the uploaded file to updatedCollection.value.artwork and manage imagePreviewUrl and removeCover state.
• frontend/src/components/common/Collection/Dialog/CreateCollection.vue
  • Renamed setArtwork function to setUrlCover.
  • Updated previewImage function to assign the uploaded file to collection.value.artwork and manage imagePreviewUrl and removeCover state.
  • Modified createCollection function to pass a spread copy of collection.value to the API.
• frontend/src/components/common/Game/Dialog/EditRom.vue
  • Renamed setArtwork function to setUrlCover.
  • Updated previewImage function to assign the uploaded file to rom.value.artwork and manage imagePreviewUrl and removeCover state.

Activity

• No specific activity (comments, reviews, approvals) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue with handling custom artwork for collections and ROMs. The changes correctly assign the uploaded file to the model, which is then sent to the backend. The function renames also improve code clarity. Overall, the changes are solid. I've added a few suggestions to refactor the previewImage function across the modified components to improve its robustness and readability.