Fix ansible_user detection condition
#1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous solution relied on matching against ANSI control codes which was brittle. This broke (again) on Ansible 2.20 because color codes are now displayed which breaks this `intersect` substring match expression. The simpler solution is to just check for the Ansible `CHANGED` output which means the raw command and connection succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous solution relied on matching against ANSI control codes which was brittle. This broke (again) on Ansible 2.20 because color codes are now displayed which breaks this
intersectsubstring match expression.The simpler solution is to just check for the Ansible
CHANGEDoutput which means the raw command and connection succeeded.