Explicit type to set BalanceRatioSelector#86
Open
3lonco wants to merge 1 commit intoros-drivers:kinetic-develfrom
Open
Explicit type to set BalanceRatioSelector#863lonco wants to merge 1 commit intoros-drivers:kinetic-develfrom
3lonco wants to merge 1 commit intoros-drivers:kinetic-develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed the error to set assigned values of BalanceRatioSelector using this package.
The same error was reported before. #30
This issue was temporally solved by setting Continuous or Once, but BalanceRatioSelector can not set the assigned values.
◆Before
When this line calls "set property",
flir_camera_driver/spinnaker_camera_driver/src/camera.cpp
Line 153 in a79c509
it is supposed to call the following code.
flir_camera_driver/spinnaker_camera_driver/include/spinnaker_camera_driver/set_property.h
Line 36 in a79c509
However, the result called the following instead of the above.
flir_camera_driver/spinnaker_camera_driver/include/spinnaker_camera_driver/set_property.h
Line 162 in a79c509
◆After
To call the setproperty having std::string in the third argument, I specified the type of "Blue" and "Red" as std::string.
◆Cause
The reason why the line called setpropety having bool is explained in the following page.
https://stackoverflow.com/questions/14770252/string-literal-matches-bool-overload-instead-of-stdstring