fix coalesce_interval_ms not working correctly#296
Open
sathyas2023 wants to merge 1 commit intoros-drivers:ros2from
Open
fix coalesce_interval_ms not working correctly#296sathyas2023 wants to merge 1 commit intoros-drivers:ros2from
sathyas2023 wants to merge 1 commit intoros-drivers:ros2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#284
The coalesce_interval_ms parameter doesn't get used properly. Spamming axis events (ex: spinning joysticks) causes rates to get very high.
should_publishis being incorrectly overwritten to true in the event loop function.The PR makes the event loop logic the same as
game_controller_nodewhich did not have this issue from my testing.