Skip to content

surpress warnings for known unused event types #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ethanholter wants to merge 2 commits into
base: ros2
Choose a base branch
from
+8 −1
Open

surpress warnings for known unused event types #307

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26b96aa
surpress warnings for known unused event types
ethanholter Nov 17, 2025
f705c5e
removed newer SDL event for Humble compatability
ethanholter Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion joy/src/joy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@

namespace joy
{
static const std::unordered_set<Uint32> ignored_sdl_events = {
SDL_CONTROLLERTOUCHPADDOWN,
SDL_CONTROLLERTOUCHPADMOTION,
SDL_CONTROLLERTOUCHPADUP
};

Joy::Joy(const rclcpp::NodeOptions & options)
: rclcpp::Node("joy_node", options)
Expand Down Expand Up @@ -435,7 +440,9 @@ void Joy::eventThread()
int success = SDL_WaitEventTimeout(&e, wait_time_ms);
if (success == 1) {
// Succeeded getting an event
if (e.type == SDL_JOYAXISMOTION) {
if (ignored_sdl_events.count(e.type) == 1) {
// ignore events which explicitly have no purpose to reduce log verbosity
} else if (e.type == SDL_JOYAXISMOTION) {
should_publish = handleJoyAxis(e);
} else if (e.type == SDL_JOYBUTTONDOWN) {
should_publish = handleJoyButtonDown(e);
Expand Down