Add DEPRECATION message to python_qt_binding import#117
Open
hellantos wants to merge 3 commits intoros-visualization:rollingfrom
Open
Add DEPRECATION message to python_qt_binding import#117hellantos wants to merge 3 commits intoros-visualization:rollingfrom
hellantos wants to merge 3 commits intoros-visualization:rollingfrom
Conversation
added 2 commits
August 30, 2022 17:57
vineet131
reviewed
Apr 15, 2023
|
|
||
| _DEPRECATION_MESSAGE = ("Using python_qt_bindings package in python is deprecated." | ||
| "The package should be replaced by python3-qtpy system dep." | ||
| "python_qt_bindings will only cater generation scrips in the future.") |
There was a problem hiding this comment.
"...cater to generating scripts..."
Slightly pedantic spelling correction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds deprecation warning to python_qt_bindings to make developers aware, they should switch their packages to pyqt.