Fix: Standardize Default Qt Binding Order to Prioritize PyQt#156
Open
idesign0 wants to merge 1 commit intoros-visualization:rollingfrom
Open
Fix: Standardize Default Qt Binding Order to Prioritize PyQt#156idesign0 wants to merge 1 commit intoros-visualization:rollingfrom
idesign0 wants to merge 1 commit intoros-visualization:rollingfrom
Conversation
Signed-off-by: Dhruv Patel <dhruvpatel2991998@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary of Change
This Pull Request standardizes the default Qt binding selection logic within
python_qt_bindingby removing the platform-specific check for macOS (Darwin).The default binding order is now uniformly set to
['pyqt', 'pyside']for all operating systems.🐛 Problem Solved
Previously, the logic for macOS was restricted:
This restriction caused GUI tools like
rqtto fail on macOS if the PySide2 package was not found, even if PyQt was correctly installed:The system was prevented from falling back to the available PyQt binding.
✅ Solution (Code Change)
The platform-specific conditional logic is replaced with the robust, standardized order:
🧪 Testing
rqtwithout import errors