Fix panic for unsupported radiotap fields in the header #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unsupported fields (such as HE) appeared in the header they would not be stored in "kinds". This resulted in panics as the fields would later be parsed as VendorNamespace and an invalid length would be stored in skip_length. This commit adds a new enum for unsupported fields so they can be stored and later skipped during parsing. Additional bounds checking is also added for ValueNamespace parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unsupported fields (such as HE) appear in the header they are not stored in the list of present fields ("kinds"). This may currently panic as the unsupported fields will be ignored and if a VendorNamespace is also present it may be parsed too early in the position of one of the unsupported fields. An invalid length will then end up in skip_length: https://github.com/rossmacarthur/radiotap/blob/trunk/src/lib.rs#L168
This commit adds a new enum for unsupported fields so they can be stored and later skipped during parsing.
Additional bounds checking is also added for VendorNamespace parsing.