Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to integrate OpenAPI specifications into the mobile app project. It includes changes to the API client, screens, configurations, and tooling to support a more structured and type-safe approach to handling API interactions. Below is a summary of the most important changes grouped by theme.
OpenAPI Integration
openapi-fetchlibrary tomobile-app/package.jsonfor API client creation.mobile-app/api-client/example.tsto define an API client using OpenAPI specifications.openapi-specifications/example.swagger.json) and TypeScript definitions for API schema (mobile-app/schema/example.d.ts). [1] [2] [3]New Screens for API Data
ItemsScreenandItemDetailsScreento display and interact with API data. These screens use the OpenAPI client for fetching data. [1] [2]mobile-app/app/example/index.tsx) and constants/types for screen parameters. [1] [2] [3]Configuration and Tooling Updates
mobile-app/package.jsonwith new scripts for mocking (mock:example) and generating TypeScript definitions (gen-schema:example) from OpenAPI specifications.schemadirectory to.gitignoreand ESLint ignores to exclude generated files. [1] [2]tsconfig.jsonwith stricter type-checking options (noUncheckedIndexedAccess) and updated module resolution settings.Documentation and Recommendations
README.mdto include details about OpenAPI specifications and their usage.42crunch.vscode-openapi) to.vscode/extensions.json.Workflow Enhancements
.github/workflows/mobile-app-test.ymlto include steps for generating API schema and running TypeScript type-checking. [1] [2]close #5