Add IRC Tramp protocol support for VTX control#165
Draft
vishwamartur wants to merge 1 commit intortlopez:masterfrom
Draft
Add IRC Tramp protocol support for VTX control#165vishwamartur wants to merge 1 commit intortlopez:masterfrom
vishwamartur wants to merge 1 commit intortlopez:masterfrom
Conversation
Related to rtlopez#163 Implement IRC Tramp protocol for VTX control. * **lib/Espfc/src/Connect/Vtx.hpp** - Add `setTrampChannel` method to handle IRC Tramp protocol. - Add `setTrampPower` method to handle IRC Tramp protocol. - Update `update` method to handle IRC Tramp protocol. * **lib/Espfc/src/Connect/Vtx.cpp** - Implement `setTrampChannel` method to handle IRC Tramp protocol. - Implement `setTrampPower` method to handle IRC Tramp protocol. - Update `update` method to handle IRC Tramp protocol. * **lib/Espfc/src/Connect/MspProcessor.cpp** - Update `processCommand` method to handle IRC Tramp protocol. - Add handling for `MSP_SET_VTX_CONFIG` command for IRC Tramp protocol. - Add handling for `MSP_VTX_CONFIG` command for IRC Tramp protocol. * **lib/Espfc/src/SerialManager.cpp** - Update `begin` method to initialize VTX for IRC Tramp protocol. - Update `update` method to handle VTX for IRC Tramp protocol.
bsvdoom
reviewed
Apr 3, 2025
Contributor
bsvdoom
left a comment
bsvdoom
left a comment
There was a problem hiding this comment.
Hey there, nice work, but I see some mismatch in the protocol handling.
I have already addressed these, and a lot more in #164 .
The channel switching seems to be working now, but not the power switching.
It might work, but I need some more time to test it, which I do not have now.
So, can you maybe pick up from there, and help me finish that PR instead?
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #163
Implement IRC Tramp protocol for VTX control.
lib/Espfc/src/Connect/Vtx.hpp
setTrampChannelmethod to handle IRC Tramp protocol.setTrampPowermethod to handle IRC Tramp protocol.updatemethod to handle IRC Tramp protocol.lib/Espfc/src/Connect/Vtx.cpp
setTrampChannelmethod to handle IRC Tramp protocol.setTrampPowermethod to handle IRC Tramp protocol.updatemethod to handle IRC Tramp protocol.lib/Espfc/src/Connect/MspProcessor.cpp
processCommandmethod to handle IRC Tramp protocol.MSP_SET_VTX_CONFIGcommand for IRC Tramp protocol.MSP_VTX_CONFIGcommand for IRC Tramp protocol.lib/Espfc/src/SerialManager.cpp
beginmethod to initialize VTX for IRC Tramp protocol.updatemethod to handle VTX for IRC Tramp protocol.