Open
Conversation
3181ab1 to
8f48137
Compare
|
I am probably going to see if I can use this in our project, as it might fix the exact issues we are facing. Our branching strategy has branches for each of our scrum stories, which results in migrations being written on various branches, some of which are sometimes dependent on one another. Whenever we have to review work that was done on other branches, our dockerized postgres databases get partial migrations from some of those branches, and if we then switch back to our own work, we have to delete our database (thus losing all our test data every single time) and get it migrated again (which is fast and all, but really annoying......). Heavy support for this PR 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bad behavior when some migrations in the db table are unknown to the current sql-migrate instance. That might happen when one branch applies some migrations and a branch lacking those migrations tries to add some of its own.
This resolves #37 by choosing option 2 of #43.
Fixed behaviors:
sql-migrate statuspanicsSome weirdness remains:
sql-migrate redoreports "nothing to do"sql-migrate statusinclude the fact of unknown statuses in the table it prints, rather than as separate warningssql-migrate statustable (probably before the migration column) that includes a status code. Maybe "!" for "unknown" and "a" for "not applied"?Is this course desirable? If so, I can resolve the pointed out weirdness either in this PR or later on.