DSL::Desc hash options are overriden by initializing them in block#706
Open
ysv wants to merge 3 commits intoruby-grape:masterfrom
Open
DSL::Desc hash options are overriden by initializing them in block#706ysv wants to merge 3 commits intoruby-grape:masterfrom
ysv wants to merge 3 commits intoruby-grape:masterfrom
Conversation
ysv
commented
Sep 12, 2018
| Class.new(Grape::API) do | ||
| desc 'Show this endpoint', nickname: 'simple' | ||
| desc 'Show this endpoint', nickname: 'simple' do | ||
| success Test |
Author
There was a problem hiding this comment.
success overrides nickname so nickname is set to default value now
Contributor
There was a problem hiding this comment.
@ysv Hash options combined with block options is deprecated. We shouldn't do that. Instead, use
desc 'Show this endpoint', nickname: 'simple', success: Testor
desc 'Show this endpoint' do
nickname 'simple'
success Test
endThe test will pass.
Author
|
closed in ruby-grape/grape#1791 |
Member
|
We should get this test merged after a passing build. Want to clean it up @ysv? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.