Add support for wildcard segments path parameters#874
Open
spaceraccoon wants to merge 1 commit intoruby-grape:masterfrom
Open
Add support for wildcard segments path parameters#874spaceraccoon wants to merge 1 commit intoruby-grape:masterfrom
spaceraccoon wants to merge 1 commit intoruby-grape:masterfrom
Conversation
7ec327f to
3262908
Compare
Contributor
Author
|
@LeFnord for your review please :) |
3262908 to
3af0f34
Compare
Member
|
@spaceraccoon … again sorry … please can you fix the conflicts, thanks |
Member
|
and maybe squash some of your PR … this one would be nice come together with #879 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #873, Ruby on Rails supports wildcard segments, such as:
would match books/some/section/last-words-a-memoir with params[:section] equals 'some/section', and params[:title] equals 'last-words-a-memoir'.
However,
grape-swaggerdoes not recognise these wildcard segments as path parameters. For example:would generate:
instead of the expected:
grape-swaggershould also recognise wildcard segments as path parameters.This adds support for wildcard segments, all tests passing locally.