[Kernel] Add tests for Exiting and Exception functions #2684
+181
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampersand
force-pushed
the
sampersand/2025-10-17/exiting-and-exceptions
branch
2 times, most recently
from
2789ea5 to
49593f8
Compare
ksss
reviewed
Oct 24, 2025
Collaborator
ksss
left a comment
ksss
left a comment
There was a problem hiding this comment.
Checking for a value like SystemExit rather than a type seems to be testing behavior, not the type.
Contributor
Author
The idea is to make sure that the exception that was thrown was one we expected from |
soutaro
reviewed
Jan 27, 2026
| def self?.fail: () -> bot | ||
| | (string message, ?cause: Exception?) -> bot | ||
| | (_Exception exception, ?_ToS? message, ?String | Array[String] | Array[Thread::Backtrace::Location] | nil backtrace, ?cause: Exception?) -> bot | ||
| | (_Exception exception, ?string | _ToS message, ?String | Array[String] | Array[Thread::Backtrace::Location] | nil backtrace, ?cause: Exception?) -> bot |
Member
There was a problem hiding this comment.
Can you explain why we need this fix on the argument type?
It looks like _ToS message would be fine technically.
Member
There was a problem hiding this comment.
#to_str is used if #to_s is not defined.
Contributor
Author
There was a problem hiding this comment.
Other way around—it tries to_str first:
class Foo
def to_s = "to_s!"
def to_str = "to_str!"
end
fail RuntimeError, Foo.new #=> -e:6:in '<main>': to_str! (RuntimeError)
sampersand
force-pushed
the
sampersand/2025-10-17/exiting-and-exceptions
branch
from
49593f8 to
052b14f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for
Kernel.{abort,exit,exit!,at_exit}andKernel.{throw,catch,raise,fail}, as well as slightly tweaking thefailsignature.Additionally, it adds in the
assert_send_type_errormethod (which is just a direct copy ofassert_send_type, but accepts a type as the second argument)