Add test coverage for bundle help <plugin_command>#9265
Merged
hsbt merged 2 commits intofix-gh-8437from Jan 26, 2026
Merged
Conversation
4 tasks
Co-authored-by: hsbt <12301+hsbt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update PR to address help flag support feedback
Add test coverage for Jan 26, 2026
bundle help <plugin_command>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for the bundle help <plugin_command> invocation pattern to ensure plugin commands work correctly with the help system.
Changes:
- Added test assertion for
bundle help greetto verify it produces the same output asbundle greet --helpandbundle greet -h
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The test suite for plugin command help support only covered
bundle greet --helpandbundle greet -h, but did not testbundle help greet. This is a common help invocation pattern that could regress without test coverage.What is your fix for the problem, implemented in this PR?
Added a third assertion to verify
bundle help greetworks correctly with plugin commands:This exercises the code path in
Bundler::CLI#helpthat detects plugin commands and delegates toBundler::Plugin.exec_command(cli, ["--help"]).Make sure the following tasks are checked
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.