Copy origin #10
Merged
Copy origin #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete rewrite from PHP to Ruby on Rails implementing phases 1-9: Phase 1: App skeleton with SQLite, Tailwind CSS, Hotwire Phase 2: Data import services for legacy XML (users, admins, content) Phase 3: Authentication - passwordless for users, bcrypt for admins Phase 4: Content browsing with year/month navigation, Turbo Frames Phase 5: Media players - PDF.js viewer, HTML5 audio player Phase 6: Search with autocomplete and debouncing Phase 7: Favorites system with Turbo Stream updates Phase 8: Admin local files upload/management with ActiveStorage Phase 9: Activity logging dashboard with usage statistics Features: - User authentication with auto-generated login IDs - Admin authentication with secure password hashing - Topic browsing by year, month, new uploads, top topics - Search across topics, tags, and authors - Favorites with instant toggle via Turbo Streams - PDF viewer with PDF.js and audio player with custom controls - Admin file management with drag-and-drop uploads - Comprehensive admin dashboard with analytics - Activity logging for user and admin actions - 365-day session duration Tech stack: Ruby 4.0.1, Rails 8.1.2, SQLite, Tailwind CSS, Hotwire Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Phase 10: Set up deployment infrastructure for both containerized and bare-metal deployments on resource-constrained devices. Docker deployment: - docker-compose.yml with persistent volumes for SQLite and uploads - docker-compose.production.yml with memory limits for Pi - docker-compose.development.yml for local development - Dockerfile.simple without Thruster for minimal footprint Systemd deployment: - config/skillrx.service with security hardening - bin/setup-production script for automated setup Helper files: - Makefile with common deployment commands - .env.example template - bin/rspec binstub for testing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dmitrytrager
force-pushed
the
copy-origin
branch
from
8925b2d to
018d3f2
Compare
- SQL Injection: Replace string interpolation in group_by_day with pre-defined SQL expressions using a whitelist hash lookup - HTTP Verb Confusion: Handle HEAD requests in store_location by checking request.get? || request.head? Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change test commands from `bin/rails test` to `bin/rspec` since the project uses RSpec for testing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
devjona
reviewed
Feb 4, 2026
| run: bin/rubocop -f github | ||
|
|
||
| test: | ||
| runs-on: ubuntu-latest |
Collaborator
There was a problem hiding this comment.
I think we're using Alpine in the Dockerfiles but we can always adjust this later.
Collaborator
Author
There was a problem hiding this comment.
But this is for host machine on CI, right?
Collaborator
There was a problem hiding this comment.
Yeah, I don't know if matters; as long as it works because sometimes it seems package names between distros vary.
devjona
reviewed
Feb 4, 2026
| @@ -0,0 +1,106 @@ | |||
| #!/bin/bash | |||
Collaborator
There was a problem hiding this comment.
We could run the app in a container as well; the only thing the machines will need is Docker; thoughts?
Collaborator
Author
There was a problem hiding this comment.
I was thinking that we may want to run it docker free. Not only because of resource, but because of how we are going to update this app on devices
devjona
reviewed
Feb 4, 2026
| @@ -0,0 +1,61 @@ | |||
| # systemd service file for SkillRx Beacon | |||
Collaborator
There was a problem hiding this comment.
This seems like something that could also be container-related; the Mini PC I have has a docker user group on it.
The commands in this file look like something that could go in a compose file.
devjona
approved these changes
Feb 4, 2026
Change test commands from `bin/rails test` to `bin/rspec` since the project uses RSpec for testing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to replicate existing app functionality within new Rails app here.
We can use this as a starting point for future development.