Normalize Paths to Prevent Cardinality Explosion#5974
Open
landongrindheim wants to merge 1 commit intomasterfrom
Open
Normalize Paths to Prevent Cardinality Explosion#5974landongrindheim wants to merge 1 commit intomasterfrom
landongrindheim wants to merge 1 commit intomasterfrom
Conversation
Our custom metrics usage is currently almost entirely consumed by the high-cardinality values of http.url_details.path, which maps to over 800k values. This change is intended to normalize the paths so that we evaluate paths in a way similar to how the config/routes.rb file defines them.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5974 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 473 473
Lines 9764 9764
=======================================
Hits 9493 9493
Misses 271 271 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖼️ Context
Our custom metrics usage is currently almost entirely consumed by the high-cardinality values of
http.url_details.path, which maps to over 800k values. This change is intended to normalize the paths so that we evaluate paths in a way similar to how the config/routes.rb file defines them.How It's Used
sidecar_nginx.response_bytes_writtenaccounts for 99.9% of our custom metrics 👇This metric uses the following configuration, in which you can observe that over the past eight hours there are more than one million values mapped to its tags. 👇
By normalizing the the paths, we will maintain insight into general access patterns while taming our use of custom metrics.