Check user passwords against HIBP on login#6119
Draft
colby-swandale wants to merge 6 commits intomasterfrom
Draft
Check user passwords against HIBP on login#6119colby-swandale wants to merge 6 commits intomasterfrom
colby-swandale wants to merge 6 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6119 +/- ##
==========================================
- Coverage 38.65% 38.56% -0.09%
==========================================
Files 487 490 +3
Lines 10718 10799 +81
==========================================
+ Hits 4143 4165 +22
- Misses 6575 6634 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Update layout for multifactor authentication prompt to use "hammy" - Adjust session controller layout to include additional actions - Modify compromised password view to conditionally display steps based on user sign-in status - Add new translation for "Continue to Dashboard" in locale file
7401de4 to
dcc8ae1
Compare
…d reset page for HIBP reset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this about?
This PR implements password breach checking against the https://haveibeenpwned.com (HIBP) database during user login. When a user attempts to sign in with a password that appears in known data breaches, the system will prompt the user to change their password.
When users have MFA enabled, they are allowed to complete login but are then redirected to reset their password. If the user does not have MFA enabled, they will be asked to complete an out-of-band password reset via the standard rubygems.org password reset email.
Why this matters
Credential stuffing attacks are one of the most common vectors for account compromise. Users frequently reuse passwords across services, so when credentials leak from one site, attackers try them everywhere. This feature proactively protects RubyGems.org users and the Ruby ecosystem from compromised credentials being used to access accounts.
Screenshots
Users With MFA after login
TODO
Users Without MFA after login