Move file reading responsibility to the CLI#109
Open
stevenocchipinti wants to merge 1 commit intorubysec:masterfrom
Open
Move file reading responsibility to the CLI#109stevenocchipinti wants to merge 1 commit intorubysec:masterfrom
stevenocchipinti wants to merge 1 commit intorubysec:masterfrom
Conversation
This means Scanner is a simple wrapper for LockfileParser and accepts the same arguments (content in the form of a string, not a directory path). This also means that Scanner is able to be called with content from anywhere (for example, github's content API) instead of a hardcoded file path and makes it more useful as a library other projects can depend on.
Member
|
Sounds reasonable. Perhaps we should add |
Author
|
Could do that. So just to clarify, would you imagine moving the file reading logic back in to and How would you expect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means
Scanneris a simple wrapper forLockfileParserand acceptsthe same arguments (content in the form of a string, not a directory path).
This also means that
Scanneris able to be called with content fromanywhere (for example, github's content API) instead of a hardcoded file
path and makes it more useful as a library other projects can depend on.