Fix install/update notifications & translation messages#112
Fix install/update notifications & translation messages#112
Conversation
| "autocorrectionDisabledEarlier": { | ||
| "message": "Die experimentelle Unicode-Autokorrekturfunktion war standardmäßig in Version 0.5.1 deaktiviert." | ||
| }, | ||
|
|
There was a problem hiding this comment.
| // manifest.json |
Keep that here (in al files), as these are the localisations for all files.
src/_locales/de/messages.json
Outdated
| "message": "✨ $ADDON_NAME aktualisiert" | ||
| }, | ||
| "updateNotificationMessage": { | ||
| "message": "Die Erweiterung „$ADDON_NAME“ wurde auf Version $VERSION aktualisiert.\nKlicken Sie, um die Versionshinweise zu sehen.\n\n$AUTOCORRECTION_MESSAGE" |
There was a problem hiding this comment.
See https://github.com/TinyWebEx/common/blob/master/CONTRIBUTING.md#translations for how these placeholders are translated, especially the official doc.
Aka you miss the translation strings here.
|
Actually, it would be great if you could try out the development version and report back whether it/everything works/you like it or what may still be adjusted, so I can do this before the next release. In case there is something to be done… 😄 Just so we know the translation works good in the browser when it is actually used. |
|
Hi @rugk, thanks for the review! I’ve added the missing placeholder definitions for the German notification strings and pushed the fix. Please let me know if anything else should be adjusted. |
|
Thanks. Did you test the changes practially? |
|
I verified the changes by checking that the notification paths now use browser.i18n.getMessage and that the localized strings resolve correctly for the added locales. I haven’t encountered any issues so far, but I’m happy to test additional cases if needed. |
|
Did you use AI? If so, please always test your results in practise. (Also always disclose you use an AI/LLM tool, IMHO.) In this case, I did some adjustments in #113 because not everything was working. |
|
Superseded by #113 |
2 participants
This PR fixes the issue where install and update notifications were always shown in English (#105).
Changes made:
Now the notifications will appear in the user's local language.
Closes #105