feat: adding docker-credential-finch compatability with native cred socket#382
Open
ayush-panta wants to merge 2 commits intomainfrom
Open
feat: adding docker-credential-finch compatability with native cred socket#382ayush-panta wants to merge 2 commits intomainfrom
ayush-panta wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: ayush-panta <ayushkp@amazon.com>
ayush-panta
force-pushed
the
finch-credhelper-update
branch
from
454a500 to
4ef1633
Compare
1 task
| // Get retrieves credentials from the Finch daemon. | ||
| func (h FinchCredentialHelper) Get(serverURL string) (string, string, error) { | ||
| if os.Getenv("USE_NATIVE_CREDSTORE") != "" { | ||
| return h.getFromCredSocket(serverURL) |
Member
There was a problem hiding this comment.
if we are not able to reuse any of it, i would say just create a different binary with finch.
Using this main doent seem to be helpful and creates a dependency on a different package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: Added rerouting to a custom get function that routes requests through a get socket in order to communicate with host-side docker-credential-helpers.
Testing done: This has been tested locally alongside changes to finch. It works as intended for standard workflows, such as pushing, pulling, and running images that require credentials.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.