Skip to content

build: add linux release automation and release automation validation#1185

Open
pendo324 wants to merge 2 commits intomainfrom
release-automation-overhaul-fix
Open

build: add linux release automation and release automation validation#1185
pendo324 wants to merge 2 commits intomainfrom
release-automation-overhaul-fix

Conversation

@pendo324
Copy link
Contributor

@pendo324 pendo324 commented Nov 15, 2024

Issue #, if available:

Description of changes

  • Adds Linux release automation (unused for now)
  • Adds release automation validation

Testing done

Changes to CI:

  • ci.yaml will continue to run on PRs.
  • ci.yaml will not run anymore on pushes to main.
  • ci-release.yaml will take the place of ci.yaml on pushes to main.
  • ci-release.yaml call ci.yaml internally.
  • ci-release.yaml will also run on PRs when changes are made to installer builders/workflows.

Contribution agreement

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pendo324 pendo324 self-assigned this Nov 15, 2024
@pendo324 pendo324 requested a review from a team as a code owner November 15, 2024 16:29
@sky1122 sky1122 requested review from austinvazquez and removed request for austinvazquez December 9, 2024 18:43
@Shubhranshu153
Copy link
Member

@pendo324 shall we close this or you do plan to get back to this in the future?

@Swapnanil-Gupta Swapnanil-Gupta marked this pull request as draft January 21, 2026 21:43
@Swapnanil-Gupta Swapnanil-Gupta force-pushed the release-automation-overhaul-fix branch from 28daa2e to fe0f564 Compare January 21, 2026 22:01
@Swapnanil-Gupta Swapnanil-Gupta force-pushed the release-automation-overhaul-fix branch 22 times, most recently from 6533074 to 60f9d36 Compare January 22, 2026 02:30
@Swapnanil-Gupta Swapnanil-Gupta force-pushed the release-automation-overhaul-fix branch 8 times, most recently from 14b534f to 7b0b98e Compare January 22, 2026 22:26
@Swapnanil-Gupta Swapnanil-Gupta marked this pull request as ready for review January 22, 2026 22:33
@Swapnanil-Gupta
Copy link
Contributor

@pendo324 PTAL when you get a chance.

@pendo324
Copy link
Contributor Author

@pendo324 PTAL when you get a chance.

LGTM just waiting for the tests to pass

@Swapnanil-Gupta Swapnanil-Gupta force-pushed the release-automation-overhaul-fix branch 5 times, most recently from 84eaac0 to 98f3955 Compare January 23, 2026 02:24
…tion

Signed-off-by: Swapnanil Gupta <swpnlg@amazon.com>
@Swapnanil-Gupta Swapnanil-Gupta force-pushed the release-automation-overhaul-fix branch from 98f3955 to f75cb0e Compare January 23, 2026 02:30
@pendo324
Copy link
Contributor Author

Ideally, we would only run the tests which are actually relevant for the changes which are being made. So for a change by the automated release-please PR (a change to the changelog file), we'd only run the release CI (and exit early or skip the rest of the CI). Same for the other CI types

@Swapnanil-Gupta Swapnanil-Gupta force-pushed the release-automation-overhaul-fix branch 3 times, most recently from f49d4f9 to 9a7bab4 Compare January 23, 2026 21:31
Signed-off-by: Swapnanil Gupta <swpnlg@amazon.com>
@Swapnanil-Gupta Swapnanil-Gupta force-pushed the release-automation-overhaul-fix branch from 9a7bab4 to ff4b395 Compare January 23, 2026 21:34
@Swapnanil-Gupta
Copy link
Contributor

Ideally, we would only run the tests which are actually relevant for the changes which are being made. So for a change by the automated release-please PR (a change to the changelog file), we'd only run the release CI (and exit early or skip the rest of the CI). Same for the other CI types

@pendo324 @Shubhranshu153 PTAL at my last commit, especially the detect-changes workflow. Open to feedback on this.

@Swapnanil-Gupta
Copy link
Contributor

Swapnanil-Gupta commented Jan 23, 2026

Also, with the detect-changes workflow, I think we can get rid of the path filters in ci.yaml and ci-release.yaml. That way we won't have to maintain the paths in two/three different places.

@pendo324
Copy link
Contributor Author

Also, with the detect-changes workflow, I think we can get rid of the path filters in ci.yaml and ci-release.yaml. That way we won't have to maintain the paths in two/three different places.

Does this behave nicely with our repo merge rules?

@Swapnanil-Gupta
Copy link
Contributor

Also, with the detect-changes workflow, I think we can get rid of the path filters in ci.yaml and ci-release.yaml. That way we won't have to maintain the paths in two/three different places.

Does this behave nicely with our repo merge rules?

I can configure CI Release workflow to run on every PR and merges into main irrespective of the changed files. The detect-changes workflow will then detect the changes in code/docs/e2e/build related items and trigger the relevant jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants