fix: container runtime full archive parse artifact path variable#1285
Open
austinvazquez wants to merge 1 commit intorunfinch:mainfrom
Open
fix: container runtime full archive parse artifact path variable#1285austinvazquez wants to merge 1 commit intorunfinch:mainfrom
austinvazquez wants to merge 1 commit intorunfinch:mainfrom
Conversation
pendo324
previously approved these changes
Feb 11, 2025
Contributor
|
Unfortunately, this now requires a rebase :( |
Contributor
Author
|
@pendo324, yep I should have opened as draft. I can rebase and try to get this in after the v1.7.0 release. |
austinvazquez
force-pushed
the
fix-container-runtime-archive-dep
branch
from
a6c48b7 to
cb26a41
Compare
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
fix-container-runtime-archive-dep
branch
from
cb26a41 to
73a3d30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Found in #1249 on Windows if environment variable is not defined then Make is not handling the same as on macOS and Linux.
Description of changes:
This change adds strip to environment variable check which will return an empty string if environment variable does not exist which is more robust on all platforms.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.