feat: Add finch vm update-os command#1470
Draft
cartrius wants to merge 1 commit intorunfinch:mainfrom
Draft
Conversation
316d195 to
2fa0874
Compare
Contributor
Author
|
Fixed rootfs cleanup and hanging test in TestUpdateOSVMAction_run |
Signed-off-by: Cartrius Phipps <cartrius@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
finch vm update-oscommand to allow users to update the OS image on their virtual machine through the CLI without having to get the latest compatible version by updating their current Finch versionTesting done:
Added unit-tests for nearly created
finch vm update-osUpdated VM OS image from
Fedora-Cloud-Base-40-1.14.aarch64-20250513213457.qcow2toFedora-Cloud-Base-Generic-41-1.4.aarch64-20250722184636.qcow2while on Finch v1.8.2 (on MacOS)I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.