fix: reschedule nightly and optimize canary runs#1691
fix: reschedule nightly and optimize canary runs#1691Shubhranshu153 wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Shubhranshu Mahapatra <shubhum@amazon.com>
| max_attempts: 3 | ||
| retry_wait_seconds: 30 | ||
| command: ./scripts/canary-deb.sh | ||
| - name: Run canary script (6 checks over ~55 minutes) |
There was a problem hiding this comment.
Is it a good idea to block this runner for 55-60 minutes when most of that time is spent sleeping?
There was a problem hiding this comment.
not really so the other case you are spinning up a runner every 5 mins and it runs for 3 mins and stops. if its a cold start then that is expensive.
There was a problem hiding this comment.
Actually yes the runners are running for only ~10-15 seconds, in that case this can be worse. i will look what other options are there
There was a problem hiding this comment.
Part of the reason for splitting the canary into a separate shellscript was so that we can easily run it on a local machine if we wanted to.
I would prefer if we keep singular canary runs within a singular script. Then call the script multiple times from either a separate bash file or within GitHub. (Or even a Go file?)
There was a problem hiding this comment.
we can do that or have an option to control it.
There was a problem hiding this comment.
I'm also okay with that. But I would like the option to do so easily before approving.
Problem
Solution
1. Reschedule Nightly Builds to 6 AM PST (14:00 UTC)
All nightly builds have been moved to 6 AM PST to avoid conflicts with patch reboot windows.
2. Optimize Deb Canary Workflow
Restructured the canary workflow to run hourly while maintaining the same monitoring frequency:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.