dockerexec: negotiate Docker API version#1042
Merged
sourishkrout merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
Contributor
Author
|
@sourishkrout PTAL |
Contributor
Thanks. I've been meaning to address this issue. |
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI test failure caused by Docker API version mismatch. The GitHub Actions environment upgraded its Docker daemon to require API version 1.44, but the code was hard-coded to use version 1.43, resulting in a "client version 1.43 is too old" error.
Changes:
- Replaced hard-coded Docker API version with automatic version negotiation
- Updated comment to clarify the rationale for the change and fixed a typo
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
sourishkrout
force-pushed
the
dev/jlewi/fixci
branch
from
9a4e4bb to
c26addb
Compare
sourishkrout
requested review from
sourishkrout
and removed request for
sourishkrout
Contributor
|
LGTM ✅ |
sourishkrout
pushed a commit
that referenced
this pull request
Feb 20, 2026
CI appears to have started failing. https://github.com/runmedev/runme/actions/runs/21955632206/job/63477672958 Error is. ``` --- FAIL: TestDockerCommand (0.00s) command_docker_test.go:22: Error Trace: /home/runner/work/runme/runme/command/command_docker_test.go:22 Error: Received unexpected error: Error response from daemon: client version 1.43 is too old. Minimum supported API version is 1.44, please upgrade your client to a newer version github.com/runmedev/runme/v3/internal/dockerexec.(*Docker).pullImage /home/runner/work/runme/runme/internal/dockerexec/docker.go:101 github.com/runmedev/runme/v3/internal/dockerexec.(*Docker).buildOrPullImage /home/runner/work/runme/runme/internal/dockerexec/docker.go:90 github.com/runmedev/runme/v3/internal/dockerexec.New /home/runner/work/runme/runme/internal/dockerexec/docker.go:49 github.com/runmedev/runme/v3/command.TestDockerCommand /home/runner/work/runme/runme/command/command_docker_test.go:21 testing.tRunner /opt/hostedtoolcache/go/1.25.7/x64/src/testing/testing.go:1934 runtime.goexit /opt/hostedtoolcache/go/1.25.7/x64/src/runtime/asm_amd64.s:1693 Test: TestDockerCommand FAIL ``` Guessing the docker version used in our images got updated but our go code is pinning to a specific version. Signed-off-by: Jeremy lewi <jeremy@lewi.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI appears to have started failing.
https://github.com/runmedev/runme/actions/runs/21955632206/job/63477672958
Error is.
Guessing the docker version used in our images got updated but our go code is pinning to a specific version.