feat(bcf): Reduce allocations by using CStr8

[killercup]

As of today, every time a field is written, a CString is allocated as the methods only take &[u8] slices, which have no guaranteed \0 termination.

Solution

This PR puts the work on the caller -- who probably either has a static list of tags or can pre-allocate and keep references to them around. It changes many of the method signatures to take a &CStr8, which is a type that ensures the data is both UTF-8 and null-terminated.

I don't have isolated measurements, but alongside some other allocation fixes, this improves the runtime performance of the tool I'm working with by 1.41x when writing large-ish (~500MB) BCF files.

Alternatives considered

1. Take a CStr

   This is a type from the std lib, so there is no external dependency being introduced. Since the tags are also used in error messages, this would introduce UTF-8 checks, albeit in the cold path.

2. Introduce a custom type.

   The cstr8 crate seems to do what we need here but is not very popular and also at version 0.1.x. Making a new custom type would put us in charge of it, with the ability to optimize further.

3. Do nothing. This costs a bunch of performance.

Downsides of this approach and future actions

• This introduces a new dependency. We might want to make this opaque and re-export most of it.
• Documentation needs to be updated to teach about this.
• We might still want to add a conversion trait and Cow-like type for convenience.
• This PR does not update all places where this could be done, only those that showed up in my profiling.

Please let me know what you think of this. I'm using this branch in the project I'm working on and found no issues, but I also don't use all of rust-htslib. I'll keep this branch up to date.

[coveralls]

Pull Request Test Coverage Report for Build 16223472312

Details

• 34 of 59 (57.63%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.2%) to 83.49%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/bcf/record.rs	31	56	55.36%

Files with Coverage Reduction	New Missed Lines	%
src/bcf/record.rs	1	75.41%

Totals
Change from base Build 16167570816:	-0.2%
Covered Lines:	2751
Relevant Lines:	3295

---

💛 - Coveralls