Check for symbols with default visibility in symbol-check#1073
Open
zmodem wants to merge 1 commit intorust-lang:mainfrom
Open
Check for symbols with default visibility in symbol-check#1073zmodem wants to merge 1 commit intorust-lang:mainfrom
zmodem wants to merge 1 commit intorust-lang:mainfrom
Conversation
Author
|
Lots of red on the CI, but that means the patch is working :-) It's flagging the outline atomics targeted by the Rust-side PR. Also
|
Contributor
|
Looking through the failures, all the naked functions fail as expected. But it seems like |
Contributor
|
Oh sorry, you mentioned that in a comment already and I missed it :) Is that something that could also be fixed in rust-lang/rust#151998? |
Author
|
Yes, I've updated that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to ensure that compiler-builtins doesn't expose any symbols with default visibility. See discussion on rust-lang/rust#151998