Conversation
Also updates ELAST to 107 since a new error was added.
|
I was also wondering if |
tgross35
left a comment
There was a problem hiding this comment.
Needs updates given the CI failure.
Which macos version is xnu-12377.1.9? If it is MacOS 26, GHA should support that now, and you could send a PR bumping it. Otherwise you can add a skip in libc-test/build.rs, but the CI bump would be much preferred.
|
Reminder, once the PR becomes ready for a review, use |
|
Push a commit to update the CI. One issue is that it doesn't seem that macOS 26 is supported on x86_64, so I didn't update the intel runner in libc/.github/workflows/ci.yaml Line 219 in df9237d |
|
With the update of macOS the CI now starts to fail: So we need #4926 as well, or ignore it somehow. I didn't see the |
Yeah, it should be removed in 1.0. So we only can add |
|
Could you do the CI bump in a separate PR? To keep things that are required from that separate from new API. |
That will mean the CI will fail, see my comment here: #4925 (comment). But I'm happy to do it. |
|
Yeah that's expected, bumping CI typically requires a few commits to update changed values like that. Getting that through before doing any brand new API just makes things simpler. |
480a620 to
728d685
Compare
|
I've dropped the CI commit (with a force push). |
Description
Adds the
ENOTCAPABLEconstant. Also updates ELAST to 107 since a new error was added.Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated