Prevent emission of (potentially colliding) type aliases in root module for inner types#3202
Open
jbg wants to merge 3 commits intorust-lang:mainfrom
Open
Prevent emission of (potentially colliding) type aliases in root module for inner types#3202jbg wants to merge 3 commits intorust-lang:mainfrom
jbg wants to merge 3 commits intorust-lang:mainfrom
Conversation
jbg
commented
Apr 30, 2025
jbg
commented
- Emit aliases in the nearest ancestor module if the parent is not a module, rather than in the root module
- If an alias would refer to itself, don't emit it (this is really a workaround for the fact that names are sometimes not unique enough, e.g. the header in Inner types are not qualified by namespace so may conflict #2056 produces two items called f_iterator)
* Emit aliases in the nearest ancestor module if the parent is not a module, rather than in the root module * If an alias would refer to itself, don't emit it (this is really a workaround for the fact that names are sometimes not unique enough, e.g. the header in rust-lang#2056 produces two items called f_iterator)
* Emit aliases in the nearest ancestor module if the parent is not a module, rather than in the root module * If an alias would refer to itself, don't emit it (this is really a workaround for the fact that names are sometimes not unique enough, e.g. the header in rust-lang#2056 produces two items called f_iterator)
emilio
reviewed
Jun 8, 2025
Contributor
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
At the very least this would benefit from a test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.