Allow generating hidden visibility functions#3304
Open
chertov wants to merge 4 commits intorust-lang:mainfrom
Open
Allow generating hidden visibility functions#3304chertov wants to merge 4 commits intorust-lang:mainfrom
chertov wants to merge 4 commits intorust-lang:mainfrom
Conversation
chertov
commented
Oct 13, 2025
chertov
commented
- add a generate_hidden_functions option so bindgen can keep functions that Clang marks with hidden/protected visibility (fixes The compiled code has no functions #2989)
- allow Function::parse to honor the new option instead of dropping those declarations unconditionally
Contributor
|
I think you need to add some test cases |
# Conflicts: # bindgen-tests/tests/tests.rs
emilio
requested changes
Oct 18, 2025
Contributor
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
Seems fine, but let's use the easier-to-manage test framework since there's nothing special about this test. Just use // bindgen-flags: --generate-hidden-functions in the header.
| .allowlist_function("hidden_fn") | ||
| .allowlist_function("protected_fn") | ||
| .header_contents("hidden.h", HIDDEN_FUNCTIONS_HEADER) | ||
| } |
Contributor
There was a problem hiding this comment.
Please reuse the existing test framework instead. I.e. add a header to bindgen-tests/tests/headers and the generated file to bindgen-tests/tests/expectations. That way we can test the whole content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.